Fix Metal type layout reflection for nested parameter blocks. #6042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheneym2
reviewed
Jan 10, 2025
| @@ -2351,7 +2362,9 @@ static SimpleLayoutInfo _getParameterGroupLayoutInfo( | |||
| // | |||
| // TODO: wouldn't it be any different to just allocate this | |||
There was a problem hiding this comment.
Is this TODO still relevant?
There was a problem hiding this comment.
I have not tested this yet. I believe there are reasons why things are done this way but I didn't have time to trace to the bottom of this.
cheneym2
approved these changes
Jan 10, 2025
juliusikkala
pushed a commit
to juliusikkala/slang
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing layout for Metal target for the following type using MetalArgumentBuffer layout:
Params::tshould receiveid=1, but due to a bug around parameter group type layout, if struct field ha ParameterBlock type and if the ParameterBlock consumes any actual non space layout units, they are not accounted for during construction of a struct layout. This PR fixes this issue so we can correct report t at id = 1.